Conversation
Introduce `merge` method to `ProgramSetQuantumTaskResult` that combines multiple results into one.
|
If this is approved before #1249, we can merge this cleanly into the |
And other minor changes
| for b in program_set.entries | ||
| ], | ||
| deviceParameters=None, # TODO: find a way to fill this in | ||
| createdAt=min(m.createdAt for m in metas if m.createdAt), |
There was a problem hiding this comment.
This apparently fails on local sim, i.e. when this list is empty?
ValueError: min() iterable argument is empty
There was a problem hiding this comment.
This is only really intended for AwsDevice; the local simulator doesn't actually need splitting
There was a problem hiding this comment.
Hm....it might still be nice for validating / emulator usage, or use in other routines? Is it easy enough to catch?
There was a problem hiding this comment.
Not completely convinced that this would be useful for validation/emulation, since the local simulator also never returns this information; I could be convinced if we find a need to add that functionality to the local simulator, and I'm happy to add it then
2 participants
Introduce
mergemethod toProgramSetQuantumTaskResultthat combines multiple results into one.Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.